Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect semantic tokens for some wildcard import statements #1545

Closed
0dinD opened this issue Jul 24, 2020 · 0 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#1518
Closed

Comments

@0dinD
Copy link
Contributor

0dinD commented Jul 24, 2020

In some wildcard import statements, only semantic tokens of type namespace are present, even when the import statement is targeting a type. This is a regression caused by eclipse-jdtls/eclipse.jdt.ls#1501, where I made the (incorrect) assumption that all wildcard imports target a package.

Environment
  • Java extension version: 0.65.0
Steps To Reproduce

Have the following code:

import java.lang.Math.*;
import static java.lang.Math.*;
Current Result

java, lang and Math are namespace tokens.

Expected Result

java and lang are namespace tokens, Math is a class token.

Additional Information

I will submit a PR with a fix for this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants