Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed latest Java textmate grammar #1637

Closed
fbricon opened this issue Sep 29, 2020 · 0 comments · Fixed by #1638
Closed

Embed latest Java textmate grammar #1637

fbricon opened this issue Sep 29, 2020 · 0 comments · Fixed by #1638

Comments

@fbricon
Copy link
Collaborator

fbricon commented Sep 29, 2020

With Java 15 support coming, new keywords sealed/non-sealed/permits need a textmate grammar update. This has been mostly done upstream in https://github.com/atom/language-java/blob/master/grammars/java.cson (although non-sealed was skipped)
Since vscode hasn't been updated yet, nor Theia nor Che-Theia, it seems safer for vscode-java to embed the latest textmate grammar for a while, until we can rely on those editors to do the right thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants