Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling error: Update project configuration #1649

Closed
liatbor opened this issue Oct 11, 2020 · 5 comments · Fixed by #1707
Closed

Spelling error: Update project configuration #1649

liatbor opened this issue Oct 11, 2020 · 5 comments · Fixed by #1707

Comments

@liatbor
Copy link

liatbor commented Oct 11, 2020

Hi,
I'm working on a Java maven project. When opening the context menu on the pom.xml, I get the option 'Update project configuration'. Both 'project' and 'configuration' should start with a capital letter so the command should be: 'Update Project Configuration'
Screen Shot 2020-10-11 at 8 14 38

Thanks

@jdneo
Copy link
Collaborator

jdneo commented Nov 18, 2020

😄 Actually this name somehow makes me a little bit confused when I saw it for the first time. IMO, naming it as Reload Project or Refresh Project conveys the idea more directly.

@rgrunber @fbricon @snjeza @testforstephen @akaroml @Eskibear @CsCherrYY Do you have any preferences here?

@rgrunber
Copy link
Member

I think this changed some time ago in m2e. They're basically using Update Project... . How do you feel about Update Project vs. Refresh/Reload ?

@jdneo
Copy link
Collaborator

jdneo commented Nov 19, 2020

😃 Update Project sounds much better! But if must choose one, I guess I'm still a fan of Reload/Refresh.

I also found that, in Eclipse, it's called Update project for Maven, and Refresh Gradle Project for Gradle.

In IntelliJ, it's called Reload Project for Maven and Gradle.


Update

After read the terms multiple times, now I think Update Project delivers the idea directly as same as reload/refresh. (Forgive me since I'm not native speaker so it's not easy for me to get such sense.)

@rgrunber Do you think it's ok to change the name from Update project configuration to Update Project? I can raise the PR for that if you think it's fine.

Meanwhile, our other commands have the same case problems so we can update them as well:
image

@rgrunber
Copy link
Member

Yes that's fine. FWIW I'm not against Refresh/Reload. I just thought that in a lot of cases, a "Refresh" is simply checking that the contents are synchronized with the filesystem, rather than performing additional steps (eg. Maven goals).

A few other things I noticed (aside from capitalization), though maybe not really needing immediate action :

  • Java: Clean the Java language server workspace -> Java: Clean Java language server workspace . In some cases you can remove some articles/adjectives without losing the meaning.

  • Java: Import Java projects in workspace -> Java: Import Java projects into workspace . 'In' implies the project is located in the workspace, but since we're referring to an action that will move the project so that it will reside in the workspace, we use 'into'.

@jdneo
Copy link
Collaborator

jdneo commented Nov 20, 2020

a "Refresh" is simply checking that the contents are synchronized with the filesystem, rather than performing additional steps (eg. Maven goals).

I see. That makes sense.

Java: Clean the Java language server workspace -> Java: Clean Java language server workspace .
Java: Import Java projects in workspace -> Java: Import Java projects into workspace

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants