@link highlighting broken when linking to class

[SamJakob]

When using the @link doc tag to refer to a class, rather than a method (which is valid), it is not highlighted, however it is for a method.

Environment

• Operating System: Windows 10
• JDK version: JavaSE-1.8
• Visual Studio Code version: 1.52.1
• Java extension version: 0.73.0

Steps To Reproduce

1. Open a Java file
2. Paste in the following Javadoc comment

/**
 * {@link String}
 * {@link String#toCharArray()}
 */

Notice how only the latter has correct syntax highlighting.

Current Result

Syntax highlighting is only applied to the @link tag when referring to a method.

Expected Result

Syntax highlighting should be applied to the @link tag when referring to a method or a class.

[fbricon]

The textmate grammar is defined in vscode itself, but the source of the grammar is actually atom, so the problem should be reported there: https://github.com/atom/language-java/issues

[SamJakob]

Filed upstream.

[0dinD]

FYI @fbricon @SamJakob this issue can also be fixed via semantic highlighting. I had this in mind for my next iteration of semantic highlighting improvements, and I've actually already implemented a fix for this specific issue, which has been sitting on my local development branch for a while.

Sadly I got busy and never got to the point of submitting a PR. But I think I'll have time to do that next week. So if all goes well I'm guessing this can make it into the next release of the extension.

Also, isn't the TextMate grammar defined by the extension itself now, since #1638? I mean, the issue still has to be fixed upstream, but we don't really depend upon VS Code anymore.

[0dinD]

eclipse-jdtls/eclipse.jdt.ls#1641 was merged, so this should be fixed now (at least via semantic highlighting) and is ready for release in the next update.

[testforstephen]

@0dinD thanks for the fix, i will close the issue.