Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo When Trying to Add Folder to Java Source Path That Is Already Included By Parent #1833

Closed
b0ssi opened this issue Mar 12, 2021 · 2 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#1687
Assignees

Comments

@b0ssi
Copy link

b0ssi commented Mar 12, 2021

Issue Type: Bug

The error that pops up when trying to add a folder to the source path (explorer > right-click on folder > "Add Folder to Java Source Path") contains a minor grammatical mistake:

Cannot add the folder '[path]' to the source path because it's parent folder is already in the source path of the project '[projectId]'.

I couldn't find where these strings are to be found spontaneously - if someone wants to point me into the right direction, happy to do it.

Extension version: 0.76.0
VS Code version: Code 1.54.1 (f30a9b73e8ffc278e71575118b6bf568f04587c8, 2021-03-04T22:38:50.094Z)
OS version: Linux x64 5.10.22-2-lts

@testforstephen
Copy link
Collaborator

https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ProjectUtils.java#L175

Feel free to open a pull request.

@b0ssi
Copy link
Author

b0ssi commented Mar 12, 2021

Cheers, PR here.

Couldn't find contribution info (spontaneously) re: what branch to branch off off/merge into and branch naming, so followed what I've seen being done in recent PRs. Let me know, easy to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants