Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire the asking importing dialog #2014

Closed
jdneo opened this issue Jul 7, 2021 · 2 comments
Closed

Retire the asking importing dialog #2014

jdneo opened this issue Jul 7, 2021 · 2 comments

Comments

@jdneo
Copy link
Collaborator

jdneo commented Jul 7, 2021

Long time ago we introduced a feature that asking user whether to import the projects when opening the workspace for the first time:

image

According to the user's selection, we will determine which server mode will be used.

Now, since VS Code has introduced the workspace trust feature as a platform solution, I think it's a good time to retire this dialog. By doing so, we can also reduce the popping-ups and get a better UX.

Any thoughts? @rgrunber @fbricon @testforstephen

// I'm willing to propose a PR if we agree on this.

@rgrunber
Copy link
Member

rgrunber commented Jul 7, 2021

Looks like we're in favour of changing the default option to "always", but would like to keep the settings itself around for now so users still have the option to change it.

If we determine at a later point that this isn't a deal breaker for anyone, then we can remove it completely.

@rgrunber rgrunber added this to the End July 2021 milestone Jul 7, 2021
@jdneo
Copy link
Collaborator Author

jdneo commented Jul 8, 2021

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants