Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating the formatter file fails silently if parent folder doesn't exist #2189

Closed
fbricon opened this issue Oct 28, 2021 · 0 comments · Fixed by #2190
Closed

Creating the formatter file fails silently if parent folder doesn't exist #2189

fbricon opened this issue Oct 28, 2021 · 0 comments · Fixed by #2190
Assignees
@snjeza
Labels
bug formatter
Milestone
End November 2021

Comments

@fbricon
Copy link
Collaborator

fbricon commented Oct 28, 2021 •
edited

  • Execute Java: Open Java Formatter Settings
  • change path to path/that/doesnt/exist/formatter.xml
  • Click Yes to ' path/that/doesnt/exist/formatter.xml ' does not exist. Do you want to create it? pop up
    => .vscode/settings.json is properly updated with new path
    => path/that/doesnt/exist/formatter.xml is not opened because it has not been created
    => No error message anywhere.

So

  • parent folder hierarchy should be created automatically if missing, so the formatter file can be created
  • an error message should appear in case of an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snjeza snjeza

Labels
bug formatter
Projects
None yet
Milestone
End November 2021
Development

Successfully merging a pull request may close this issue.

Creating the formatter file fails silently if parent folder doesn't exist snjeza/vscode-java
2 participants
@fbricon @snjeza