-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java server refreshing the workspace (cleaning and building) for each restart which is taking a lot of time #2222
java server refreshing the workspace (cleaning and building) for each restart which is taking a lot of time #2222
Comments
Is the code base available anywhere to try to reproduce this ? @fbricon are there any enhancement requests you're aware of on JDT-LS or m2e to allow a Maven import to happen without also doing a project rebuild ? |
@bitsInnovate00 @rgrunber Could you, please, check https://github.com/snjeza/vscode-test/raw/master/java-1.1.0.vsix ? |
I'm not sure if your fix improves anything for me. If I import lemminx (as an example), it takes about 30s with or without your vsix. In fact, I can see that new classfiles are still generated on import, and the build seems to happen as well. I guess the problem is a user/process could easily modify the sources between the language server shutting off and starting back up, so it makes sense to rebuild. Disabling |
@rgrunber Could you, please, try spring-petclinic? |
@snjeza I just used your |
@snjeza . version |
FWIW, I tried with spring-petclinic initially and noticed there was some improvement in the time it takes to finish the build (and get to |
@rgrunber could you, please, check https://github.com/snjeza/vscode-test/raw/master/java-1.1.1.vsix with enabled and disabled the |
With |
@rgrunber Could you, please, test with |
With |
@rgrunber When restarting a workspace, Java LS with the PR doesn't run the clean workspace action. See eclipse-jdtls/eclipse.jdt.ls@999001c#diff-f23d0258ce24117c110acd6753e8490a09fbdf0bc039d662bdffe279c8c28469R320 |
I've tried again with lemminx, since maybe spring-petclinic builds too quickly on my machine. It went from ~17s normally, to ~3s with this change. That's definitely a big deal . Yes, I can confirm the "Clean workspace..." doesn't run any longer. |
[vscode java server refreshing the workspace (cleaning and building) for each restart which is taking a lot of time]
Environment
Steps To Reproduce
Please refer the jira. As per the direction , creating the issue in vscode-java
I have a workspace with 5 maven projects which is already refreshed by the vscode java server. But if I simply restart the workspace, its again repeating the workspace refreshment with cleaning and building which is taking a lot of CPU and time. Why its redoing the same thing again and again
[attach a sample project reproducing the error]
attach logs
Current Result
The workspace restart is consuming a lot of CPU and time for the vscode java server for doing the workspace refresh
Expected Result
The worspace should refresh and restart very quickly
Additional Informations
NA
The text was updated successfully, but these errors were encountered: