Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

”Go to References" result contain wrong referrences #2227

Closed
whinc opened this issue Nov 25, 2021 · 4 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#1984
Closed

”Go to References" result contain wrong referrences #2227

whinc opened this issue Nov 25, 2021 · 4 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#1984
Assignees
@snjeza
Labels
bug navigation
Milestone
End January 2022

Comments

@whinc
Copy link

whinc commented Nov 25, 2021

[provide a description of the issue]

Environment
  • Operating System: macos 10.14.6
  • JDK version: openjdk 11.0.11
  • Visual Studio Code version: 1.62.3
  • Java extension version: v1.0.0
Steps To Reproduce
  1. define custom User class
  2. click context menu "Go to referrences" on User class

[Please attach a sample project reproducing the error]
Please attach logs

Current Result

image

Expected Result
Additional Informations
@fbricon
Copy link
Collaborator

fbricon commented Nov 25, 2021

Can you please provide a sample project reproducing this issue?

@whinc
Copy link
Author

whinc commented Nov 27, 2021

@fbricon it'a a demo below generated by spring initializr

demo.zip

image

@snjeza snjeza self-assigned this Dec 29, 2021
@snjeza snjeza mentioned this issue Jan 5, 2022
Merged
@rgrunber rgrunber added this to the End January 2022 milestone Jan 11, 2022
@rgrunber
Copy link
Member

rgrunber commented Jan 11, 2022 •
edited

@snjeza Wouldn't we also have to adjust things like CodeLensHandler (which uses its own SearchEngine for references) ?

Implementations seem to already filter out inaccurate matches, so they should be fine.

@snjeza
Copy link
Contributor

snjeza commented Jan 11, 2022

Wouldn't we also have to adjust things like CodeLensHandler (which uses its own SearchEngine for references) ?

@rgrunber I have done it. See eclipse-jdtls/eclipse.jdt.ls@1aa927b

@rgrunber rgrunber changed the title ”Go to Referrences" result contain wrong referrences ”Go to References" result contain wrong referrences Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snjeza snjeza

Labels
bug navigation
Projects
None yet
Milestone
End January 2022
Development

Successfully merging a pull request may close this issue.

'Go to References' contains wrong references snjeza/eclipse.jdt.ls
4 participants
@fbricon @snjeza @rgrunber @whinc