Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Type Hierarchy breaks in vscode-insiders #2524

Closed
Eskibear opened this issue Jun 23, 2022 · 3 comments · Fixed by #2517
Closed

Show Type Hierarchy breaks in vscode-insiders #2524

Eskibear opened this issue Jun 23, 2022 · 3 comments · Fixed by #2517

Comments

@Eskibear
Copy link
Contributor

Version: 1.69.0-insider (user setup)
Commit: f361c5b71d6676cfc6de97cdb1cc40b08bf7d994
Date: 2022-06-22T05:17:09.661Z
Electron: 18.3.4
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.22000

Root cause is renaming of ref-viewlet's publisher. On our side, we can ask both old/new extension ids for compatibility, by PR #2517 . VS Code team will also take action to keep some backward compatibility. More details in see microsoft/vscode#152213 (comment)

@jdneo jdneo added the upstream label Jun 23, 2022
@jdneo
Copy link
Collaborator

jdneo commented Jun 23, 2022

I saw the upstream name has been changed back to vscode.xxx. Is ms-vscode.xxx already released?

@CsCherrYY
Copy link
Contributor

Is ms-vscode.xxx already released?

The extension name is always ms-vscode.xxx since it's available as an API, and we also use the ms-vscode.xxx to fetch the extension API.

Currently we should track microsoft/vscode#152834, the milestone is June so that there might be a solution before the new release of VS Code stable?

@Eskibear
Copy link
Contributor Author

So far in all stable versions, it's ms-vscode.
In the coming June release (latest insiders), it's changed to vscode, and will stay as vscode for consistency.

On VS Code side, they will probably change implementation of getExtension so that it will return the instance even if you are using old publisher ms-vscode, for compatibility.

On our side, before that happen, to unblock the broken use case in insiders (and future releases), we should call getExtension using new publisher. To keep compatibility with current versions of vscode, fallback to getExtension with older publisher if the new one doesn't work.

@testforstephen testforstephen linked a pull request Jun 23, 2022 that will close this issue
@testforstephen testforstephen added this to the End June 2022 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants