Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong JRE embedded in pre-release package #2559

Closed
Eskibear opened this issue Jul 13, 2022 · 2 comments · Fixed by #2560
Closed

wrong JRE embedded in pre-release package #2559

Eskibear opened this issue Jul 13, 2022 · 2 comments · Fixed by #2560
Assignees
Milestone

Comments

@Eskibear
Copy link
Contributor

For universal platform, should pre-pack no JRE. Probably because you didn't clear the staging folder.

image

@CsCherrYY

@CsCherrYY
Copy link
Contributor

the root cause is that we didn't clean jre folder for generic pre-release versions:

vscode-java/Jenkinsfile

Lines 95 to 96 in 6c000d3

// Clean up embedded jre folder from previous build
sh 'npx gulp clean_jre'

I'll add a PR to fix it.

@rgrunber
Copy link
Member

Not saying we need to do this now, but down the road, we could potentially simplify basic flag inclusions like --pre-release by storing the flag (or empty value) in variable. That way one can always pass that to the package/publish call :

https://github.com/redhat-developer/vscode-xml/blob/faaac4e08384d7324bd0f0fbd61d2de055642f33/Jenkinsfile#L88
https://github.com/redhat-developer/vscode-xml/blob/faaac4e08384d7324bd0f0fbd61d2de055642f33/Jenkinsfile#L125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants