CodeLens for Interfaces #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
reviewed
Jul 11, 2017
package.json
Outdated
| @@ -106,6 +106,11 @@ | |||
| "default": true, | |||
| "description": "Enable/disable the references code lens." | |||
| }, | |||
| "java.implementationsCodeLens.enabled": { | |||
| "type": "boolean", | |||
| "default": false, | |||
There was a problem hiding this comment.
wondering whether we should enable it by default.
@gorkem ?
|
Can you please also update the readme, to describe the new preference key? |
snjeza
force-pushed
the
issue-99
branch
4 times, most recently
from
60feb5d
to
5d68577
Compare
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-jdtls/eclipse.jdt.ls#99
I have added the java.implementationsCodeLens.enabled property, false by default.
To enable the codeLens implementors, you have to add the following:
The implementations will be shown for interfaces and abstract classes.
Requires eclipse-jdtls/eclipse.jdt.ls#301
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com