Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support of lombok #2805

Closed
hannah23280 opened this issue Nov 17, 2022 · 7 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#2339
Closed

Better support of lombok #2805

hannah23280 opened this issue Nov 17, 2022 · 7 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#2339

Comments

@hannah23280
Copy link

vscode - v1.72.2
vscode-java - v1.12.0
Hi,
I know that vscode-java support lombok, however, I do wish it can make the support even better.

Currently, 2 things requesting for enhancement

 ```
     Test.java

        @Getter
        @Setter
       class Test{
            private int a;
            private int b;
            private int c
      }
 ```
 ```
    Main.java
          var test = new Test();
         test.getC();
 ```
  1. Jump to the field of the lombok-annotated class corresponding to the getter and setter method
    If we are to right click on the getC() method, and select "Go to Implementation", it will open the Test.java file and bring me to the top of the class, where the @getter is. However, most of the time, we want to go directly to the field that is associated with getC() method, which unfortunately, vscode-java doesn't work in this manner. Intellij , however, does this perfectly well.

  2. Refactor the field name should auto refactor all corresponding getter and setter of that field.
    If I am to change the field name, say c become xxxx, all the test.getC() should auto update to become test.getXXXX(), rather than expect developer to manually change all of them.
    Again, Intellij does this well.

@snjeza
Copy link
Contributor

snjeza commented Nov 21, 2022

@zymotik
Copy link

zymotik commented Nov 23, 2022

It would be great to support the SuperBuilder annotation 👍

microsoft/vscode-lombok#62

@snjeza
Copy link
Contributor

snjeza commented Nov 23, 2022

@zymotik Could you, please, provide a project example reproducing the error?

@zymotik
Copy link

zymotik commented Nov 23, 2022

I will ask my highly esteemed colleague @AndreySyagrovskiy 👍

Thank you for your speedy reply @snjeza

@zymotik
Copy link

zymotik commented Nov 28, 2022

Sorry for the delay, example code to demonstrate the annotation issue in Visual Studio Code. See the readme of the code repository: https://github.com/zymotik/redhat-developer-vscode-java-issue-2805

@snjeza
Copy link
Contributor

snjeza commented Nov 28, 2022

@zymotik Could you, please, create a new issue?

@zymotik
Copy link

zymotik commented Nov 29, 2022

@snjeza, Issue #2819 created. We appreciate your time, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants