Add workspace/executeCommand request #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Execute Workspace Command | ||
| */ | ||
| export const EXECUTE_WORKSPACE_COMMAND = 'java.execute.workspaceCommand'; |
There was a problem hiding this comment.
please add command java.execute.workspaceCommand to the activationEvents list in package.json
There was a problem hiding this comment.
Echo here. This is to make sure the extension is properly activated before the command is triggered.
yaohaizh
force-pushed
the
yaohai_extensionpoint
branch
from
03f243d
to
e630e2e
Compare
akaroml
suggested changes
Sep 12, 2017
| /** | ||
| * Execute Workspace Command | ||
| */ | ||
| export const EXECUTE_WORKSPACE_COMMAND = 'java.execute.workspaceCommand'; |
There was a problem hiding this comment.
Echo here. This is to make sure the extension is properly activated before the command is triggered.
|
@yaohaizh can you please solve the merge conflict so we can merge it? |
Signed-off-by: Yaohai Zheng <yaozheng@microsoft.com>
yaohaizh
force-pushed
the
yaohai_extensionpoint
branch
from
e630e2e
to
ee10581
Compare
|
Resolved conflication |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaohai Zheng yaozheng@microsoft.com