Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gradle version doesn't work #2942

Closed
v-yuyul opened this issue Feb 16, 2023 · 3 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#2472
Closed

Upgrade gradle version doesn't work #2942

v-yuyul opened this issue Feb 16, 2023 · 3 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#2472
Labels
Gradle regression
Milestone
Mid February 2023

Comments

@v-yuyul
Copy link

v-yuyul commented Feb 16, 2023

Environment
  • Operating System: Mac
  • JDK version: 17.0.6
  • Gradle version: 7.5.1
  • Visual Studio Code version: 1.75.1
  • Java extension version: 1.15.0
Steps To Reproduce
  1. Open https://github.com/redhat-developer/vscode-java/tree/master/test/resources/projects/gradle/simple-gradle
  2. Select 'Upgrade Gradle to 7.4.2' when it prompts 'Can't use java 17.x and gradle 4.x to import Gradle project xxx' > Wait for it completed
Current Result

The gradle version of the project isn't upgraded actually. And there is no upgrade installing process output.
upgrade

Expected Result

Can upgrade gradle version.
@fbricon
Copy link
Collaborator

fbricon commented Feb 16, 2023 •
edited

I confirm this is a regression from 1.14

@fbricon
Copy link
Collaborator

fbricon commented Feb 16, 2023

Actually no it worked for me, I was just being stupid

@CsCherrYY
Copy link
Contributor

I think it's a regression introduced by https://github.com/eclipse/eclipse.jdt.ls/pull/2304/files#diff-4be4f273e609fde1220c2d89f532f1fe207f280c100126555c3747fcf44d18d8, I'm preparing a fix.

@CsCherrYY CsCherrYY mentioned this issue Feb 16, 2023
Merged
@rgrunber rgrunber added this to the Mid February 2023 milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Gradle regression
Projects
None yet
Milestone
Mid February 2023
Development

Successfully merging a pull request may close this issue.

Enable upgrading the Gradle version in projects without GradleBuild CsCherrYY/eclipse.jdt.ls
4 participants
@fbricon @rgrunber @v-yuyul @CsCherrYY