Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully recover from failure to detect the language server project in sibling directory #3107

Closed
rgrunber opened this issue May 19, 2023 · 0 comments · Fixed by #3113
Closed

Comments

@rgrunber
Copy link
Member

rgrunber commented May 19, 2023

Our CONTRIBUTING.md server-side setup talks about how to set up vscode-java with eclipse.jdt.ls (placing them as sibling directories) in order to ensure npm run build-server builds eclipse.jdt.ls and uses the resulting content in the server/ folder of vscode-java.

However, we also have a gulp task that fetches the latest pre-built language server (eclipse.jdt.ls) from http://download.eclipse.org/jdtls/snapshots/jdt-language-server-latest.tar.gz . It would be good to integrate this workflow in the case a user has not properly set up a sibling directory.

I don't know if I'd do this for npm run build-server though maybe we create a separate task called npm run build that either performs build-server if eclipse.jdt.ls is detected, or the download_server task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant