Second argument is replaced upon completing the first argument in a method call

[michelkaporin]

Moved from microsoft/vscode-java-pack#12:

• VSCode Version: Latest Insiders
• OS Version: Mac OS

Steps to Reproduce:

1. Insert cursor before the first argument (that accesses some property) to the method.
2. Start typing new argument that also accesses property.
3. On suggestion appearance, press Tab to enter suggestion value
   It replaces the old first argument instance with the property from the new argument.

Sample code:

public class Test {
    public int testInt;

    public boolean method(int x, int y, int z) {
        return true;
    }
}

public class Main {
    public static void main(String[] args) {
        Test t = new Test();
        t.method(t.testInt, t.testInt);
    }
}

[gorkem]

@snjeza If it helps I can easily repro this.

[snjeza]

@gorkem Thanks. I have reproduced it. It isn't reproducible in Eclipse.

[SummerSun]

Did repro it in Mac OS with VSCode Latest Insiders. But in Windows 10, the issue is a little different.

Repro steps are the same.

[SummerSun]

Tried with vscode 1.21.0 with windows 10, easily repro this issue.

Attach the request from client, hope it helps.

[Trace - 3:41:00 PM] Sending notification 'textDocument/didChange'.
Params: {
    "textDocument": {
        "uri": "file:///d%3A/java-debug/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/Breakpoint.java",
        "version": 22
    },
    "contentChanges": [
        {
            "range": {
                "start": {
                    "line": 109,
                    "character": 35
                },
                "end": {
                    "line": 109,
                    "character": 45
                }
            },
            "rangeLength": 10,
            "text": "className()"
        }
    ]
}

[fbricon]

the fix introduces a new preference : java.completion.overwrite (boolean). The default (current) behaviour has the value set to true. @michelkaporin you'll be able to change it to false to get what you want.