Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export the utility method requirements.resolveRequirements() as extension API #639

Closed
testforstephen opened this issue Sep 14, 2018 · 4 comments

Comments

@testforstephen
Copy link
Collaborator

Currently the Java Debugger and Test Runner have the duplicated logic to check JDK installation directory. Could the vscode-java return the resolved RequirementsData value as the return value of activate function? By this way, other extensions can get the resolved java_home info directly.

   const extension = vscode.extensions.getExtension("redhat.java");
   const extensionApi = await extension.activate();
   return extensionApi.requirementsData;
@ThadHouse
Copy link

I'm having to do the same thing in an extension that runs gradle commands, so this would definitely be something very useful to any extension that needs the JDK.

@fbricon
Copy link
Collaborator

fbricon commented Sep 16, 2018

@testforstephen can you provide a PR for that?

@testforstephen
Copy link
Collaborator Author

@fbricon yeah, i submit a PR for this, please help a review.

@fbricon fbricon added this to the Mid September 2018 milestone Sep 17, 2018
@fbricon fbricon closed this as completed Sep 17, 2018
@fbricon
Copy link
Collaborator

fbricon commented Sep 17, 2018

Thanks for the fix @testforstephen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants