Issues with Micronaut and Visual Studio Code with Java #693

graemerocher · 2018-10-29T09:23:52Z

I had a chat with @fbricon at CodeOne and we got the basics of Micronaut working with Code however there are a couple of areas that I can't seem to get to work.

Gradle support doesn't seem to work at all, the annotation processors are simply not applied.
Maven support partially works. Annotation processors are applied to sources in src/main/java, but tests don't work because the processors are not applied to src/test/java.

Environment

Operating System: OS X
JDK version: Java 8 or 11
Visual Studio Code version: 1.28.2 (1.28.2)
Java extension version: Extension Package 0.4.0

Steps To Reproduce for Gradle

Clone the repo https://github.com/micronaut-projects/micronaut-examples
cd hello-world-java
Run gradle eclipse
Run code .

Current Result

The application can be run but if you hit http://localhost:8080/hello/john you receive a 404 and although the tests pass they pass because the test is skipped because it isn't configure as a bean.

Expected Result

The test should not be skipped and http://localhost:8080/hello/john should not 404

Steps To Reproduce for Maven

Clone the repo https://github.com/micronaut-projects/micronaut-examples
cd hello-world-java
Remove the build.gradle (so that VSC uses the pom.xml)
Run code .

Current Result

The result is better than with Gradle, the application can be run and if you hit http://localhost:8080/hello/john you get the right result. This means the annotation processors are applied to src/main/java.

However if you run a test the test is skipped because the annotation processor are not applied. If you however run ./mvnw test the test is not skipped because the processors are applied

Expected Result

The test should not be skipped because annotation processors should be applied to test sources.

The text was updated successfully, but these errors were encountered:

fbricon · 2018-10-29T15:57:26Z

so we should see extra class files automatically generated in the test ouput directory?

graemerocher · 2018-10-29T16:05:23Z

Yes that is correct

fbricon · 2018-10-29T17:35:24Z

Ok so the gradle integration, I need to look at separately, because the eclipse/buildship/gradle combo does its own thing and I'm not too familiar with gradle.

As for the Maven integration, I was able to reproduce the same behavior in Eclipse, where no extra test classes were generated under target/test-classes, when you import the project.
But, if you make a change to src/test/java/example/HelloClient.java, AP kicks in, those test classes appear. Same thing in vscode. So I suspect something's fishy in JDT APT. cc @brychcy.

The next problem is, when running HelloControllerTest, the test is still skipped. No idea why for now.

fbricon · 2018-10-29T18:38:21Z

@graemerocher skipped test is a micronaut issue. Fresh clone of the project then
cd hello-world-java; ./mvnw clean verify gets you:

[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ hello-world ---
[INFO] Surefire report directory: /Users/fbricon/Dev/souk/micronaut-examples/hello-world-java/target/surefire-reports

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running example.HelloControllerTest
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

graemerocher · 2018-10-30T13:37:35Z

@fbricon yeah it looks like Maven is not applying the annotation processors to the test source code the same was as Gradle. I am investigating the issue

fbricon · 2018-10-30T13:59:41Z

Chances are, once the problem with Maven skipping the tests is fixed, it'll also work in Eclipse, then in VS Code

graemerocher · 2018-10-30T14:27:12Z

I pushed some changes to the pom.xml that resolves the issue with ./mvnw clean verify however I am still seeing the issue with test being skipped in VSC

brychcy · 2018-11-05T09:32:45Z

I cannot reproduce the problem in eclipse (using the master of jdt, m2e and m2e-apt), but maybe because of the pom.xml changes.

snjeza · 2018-11-07T17:56:01Z

@fbricon @graemerocher Could you try to add the following dependency:

<dependency>
	<groupId>io.micronaut.test</groupId>
	<artifactId>micronaut-test-spock</artifactId>
	<version>1.0.0.RC1</version>
	<scope>test</scope>
</dependency>

fbricon · 2018-11-16T20:51:38Z

Yeah I confirm adding the micronaut-test-spock dependency immediately triggers proper generation of test byte code. Without even touching the .factorypath. Since most of the dependencies are groovy stuff, I thought adding junit:4.12 to the dependencies instead would do the trick, but no dice. There's something fishy here, related to spock. @snjeza any idea why? How did you find out about spock?

fbricon · 2018-11-16T20:52:39Z

@brychcy I get the exact same behavior in Eclipse 2018-12 M2

snjeza · 2018-11-16T22:38:10Z

How did you find out about spock?

I have reviewed the log and noticed that io.micronaut.test.extensions.spock.MicronautSpockExtension is missing.

fbricon · 2018-11-16T23:31:40Z

Wow, I don't know how I missed that 🤦‍♂️

Caused by: org.eclipse.jdt.internal.compiler.problem.AbortCompilation: Pb(324) The type io.micronaut.test.extensions.spock.MicronautSpockExtension cannot be resolved. It is indirectly referenced from required .class files
	at org.eclipse.jdt.internal.compiler.problem.ProblemHandler.handle(ProblemHandler.java:162)
	at org.eclipse.jdt.internal.compiler.problem.ProblemHandler.handle(ProblemHandler.java:229)
	at org.eclipse.jdt.internal.compiler.problem.ProblemReporter.handle(ProblemReporter.java:2550)
	at org.eclipse.jdt.internal.compiler.problem.ProblemReporter.isClassPathCorrect(ProblemReporter.java:5005)
	at org.eclipse.jdt.internal.compiler.lookup.UnresolvedReferenceBinding.resolve(UnresolvedReferenceBinding.java:123)
	at org.eclipse.jdt.internal.compiler.lookup.UnresolvedAnnotationBinding.getElementValuePairs(UnresolvedAnnotationBinding.java:62)
	at org.eclipse.jdt.internal.compiler.apt.model.AnnotationMirrorImpl.getElementValues(AnnotationMirrorImpl.java:119)
	at io.micronaut.annotation.processing.JavaAnnotationMetadataBuilder.readAnnotationRawValues(JavaAnnotationMetadataBuilder.java:198)
	at io.micronaut.annotation.processing.JavaAnnotationMetadataBuilder.readAnnotationRawValues(JavaAnnotationMetadataBuilder.java:55)
	at io.micronaut.inject.annotation.AbstractAnnotationMetadataBuilder.populateAnnotationData(AbstractAnnotationMetadataBuilder.java:283)
	at io.micronaut.inject.annotation.AbstractAnnotationMetadataBuilder.buildStereotypeHierarchy(AbstractAnnotationMetadataBuilder.java:535)
	at io.micronaut.inject.annotation.AbstractAnnotationMetadataBuilder.processAnnotationStereotype(AbstractAnnotationMetadataBuilder.java:567)
	at io.micronaut.inject.annotation.AbstractAnnotationMetadataBuilder.buildInternal(AbstractAnnotationMetadataBuilder.java:508)
	at io.micronaut.inject.annotation.AbstractAnnotationMetadataBuilder.build(AbstractAnnotationMetadataBuilder.java:86)
	at io.micronaut.annotation.processing.AnnotationUtils.getAnnotationMetadata(AnnotationUtils.java:125)
	at io.micronaut.annotation.processing.visitor.LoadedVisitor.matches(LoadedVisitor.java:94)
	at io.micronaut.annotation.processing.TypeElementVisitorProcessor.lambda$null$1(TypeElementVisitorProcessor.java:133)
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174)
	at java.util.HashMap$ValueSpliterator.forEachRemaining(HashMap.java:1625)
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
	at io.micronaut.annotation.processing.TypeElementVisitorProcessor.lambda$process$2(TypeElementVisitorProcessor.java:133)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
	at java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1553)
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
	at io.micronaut.annotation.processing.TypeElementVisitorProcessor.process(TypeElementVisitorProcessor.java:131)
	at org.eclipse.jdt.internal.compiler.apt.dispatch.RoundDispatcher.handleProcessor(RoundDispatcher.java:142)
	... 24 more

@graemerocher does it make sense? I need to figure out why Maven CLI adds it to the classpath, but it is ignored in m2e

graemerocher · 2018-11-17T08:04:45Z

@fbricon It does make sense. Note however the missing Spock dependency is by design. We support Spock and Junit 5 with only one needing to be on the class path

Although the annotation does reference a class that is not there. This is not an issue with javac nor an issue with Spock or Junit at runtime

I don’t want users to have to use 2 different annotations for each framework so what we will probably do is try and catch the exception in our annotation processors

However to me this is a bug in the Eclipse APT support as it behaves differently to javac and runtime Java

graemerocher · 2018-11-22T16:32:12Z

I filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=541466 to track this issue in the Eclipse APT implementation

fbricon · 2018-12-18T01:26:33Z

@graemerocher when's the next release of micronaut-inject containing the fix?

graemerocher · 2018-12-18T07:30:25Z

@fbricon Either today or tomorrow, just wrapping up the last few issues

fbricon · 2019-01-08T14:15:37Z

Maven flavour of helloworld-java now works OOTB (once you set <micronaut.version>1.0.2</micronaut.version>)

To get JDT APT support for Gradle projects, you need explicit .factorypath, .settings/org.eclipse.jdt.apt.core.prefs, .settings/org.eclipse.jdt.core.prefs manipulation in the build.gradle file. The process is documented here.

graemerocher · 2019-01-08T14:16:23Z

Yes it does, closing this now. Thanks!

fbricon · 2019-01-08T14:29:01Z

FTR, providing OOTB annotation processing support for Gradle requires Gradle/Buildship to be enhanced. Go vote for it.

ecmel · 2020-10-12T22:09:53Z

Annotation processing for Micronaut maven projects is not working.

fbricon added bug Maven Gradle annotation-processing labels Oct 29, 2018

fbricon mentioned this issue Oct 30, 2018

Tests are skipped when run with Maven micronaut-projects/micronaut-examples#23

Closed

fbricon mentioned this issue Nov 16, 2018

micronaut-test-core pom.xml is missing micronaut-test-spock dependency micronaut-projects/micronaut-test#5

Closed

This was referenced Nov 22, 2018

Fix compilation issue with Eclipse APT implementation micronaut-projects/micronaut-core#961

Closed

Fix compilation issue with Eclipse APT implementation micronaut-projects/micronaut-core#963

Merged

graemerocher closed this as completed Jan 8, 2019

fbricon mentioned this issue Jan 8, 2019

Update examples to use micronaut 1.0.2 micronaut-projects/micronaut-examples#35

Closed

fbricon added this to the Mid January 2019 milestone Jan 8, 2019

bangroot mentioned this issue Oct 24, 2019

annotationProcessorPaths not firing during compile #1120

Open

Crow-EH mentioned this issue Sep 10, 2022

Remove workarround for old Eclipse APT implementation micronaut-projects/micronaut-core#7984

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issues with Micronaut and Visual Studio Code with Java #693

Issues with Micronaut and Visual Studio Code with Java #693

graemerocher commented Oct 29, 2018

fbricon commented Oct 29, 2018

graemerocher commented Oct 29, 2018

fbricon commented Oct 29, 2018

fbricon commented Oct 29, 2018 •

edited

graemerocher commented Oct 30, 2018

fbricon commented Oct 30, 2018

graemerocher commented Oct 30, 2018

brychcy commented Nov 5, 2018

snjeza commented Nov 7, 2018

fbricon commented Nov 16, 2018 •

edited

fbricon commented Nov 16, 2018

snjeza commented Nov 16, 2018

fbricon commented Nov 16, 2018

graemerocher commented Nov 17, 2018

graemerocher commented Nov 22, 2018

fbricon commented Dec 18, 2018

graemerocher commented Dec 18, 2018

fbricon commented Jan 8, 2019

graemerocher commented Jan 8, 2019

fbricon commented Jan 8, 2019

ecmel commented Oct 12, 2020

Issues with Micronaut and Visual Studio Code with Java #693

Issues with Micronaut and Visual Studio Code with Java #693

Comments

graemerocher commented Oct 29, 2018

Environment

Steps To Reproduce for Gradle

Current Result

Expected Result

Steps To Reproduce for Maven

Current Result

Expected Result

fbricon commented Oct 29, 2018

graemerocher commented Oct 29, 2018

fbricon commented Oct 29, 2018

fbricon commented Oct 29, 2018 • edited

graemerocher commented Oct 30, 2018

fbricon commented Oct 30, 2018

graemerocher commented Oct 30, 2018

brychcy commented Nov 5, 2018

snjeza commented Nov 7, 2018

fbricon commented Nov 16, 2018 • edited

fbricon commented Nov 16, 2018

snjeza commented Nov 16, 2018

fbricon commented Nov 16, 2018

graemerocher commented Nov 17, 2018

graemerocher commented Nov 22, 2018

fbricon commented Dec 18, 2018

graemerocher commented Dec 18, 2018

fbricon commented Jan 8, 2019

graemerocher commented Jan 8, 2019

fbricon commented Jan 8, 2019

ecmel commented Oct 12, 2020

fbricon commented Oct 29, 2018 •

edited

fbricon commented Nov 16, 2018 •

edited