Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc Syntax highlighting #94

Closed
3ximus opened this issue Nov 15, 2016 · 15 comments
Closed

Javadoc Syntax highlighting #94

3ximus opened this issue Nov 15, 2016 · 15 comments

Comments

@3ximus
Copy link

3ximus commented Nov 15, 2016

Not sure if i should ask this here, but would it be possible for you to add syntax highlighting for javadoc?

@fbricon
Copy link
Collaborator

fbricon commented Nov 15, 2016

Can you be more specific?

This is hovering over the String class:

capture d ecran 2016-11-15 a 12 30 07

@3ximus
Copy link
Author

3ximus commented Nov 15, 2016

I meant custom javadoc like this:
2016-11-15-184646_1104x174_scrot

as I have for example on eclipse or Gvim:
2016-11-15-184723_999x129_scrot

Also hovering over a class (String for example ) doesnt give me any javadoc popup like the one you showed...

@fbricon
Copy link
Collaborator

fbricon commented Nov 15, 2016

I see. And I agree that's a perfectly legitimate request.

You only get javadoc on hover when the java file is opened within a project directory (must be an Maven or Eclipse project), not as a standalone file.

@3ximus
Copy link
Author

3ximus commented Nov 15, 2016

I do have a maven project open. Everything works, like completion and my custom javadoc is displayed, but not javadoc of classes or methods that I didnt define.
Dont know if it matters but I have java.home set to: "java.home": "/usr/lib/jvm/java-8-openjdk", and I'm running this on Arch Linux.

@fbricon
Copy link
Collaborator

fbricon commented Nov 15, 2016

While javadoc syntax highlighting is probably fixable in vscode-java, I believe this is something that should be fixed upstream, in https://github.com/Microsoft/vscode/blob/master/extensions/java/syntaxes/java.json. @gorkem WDYT?

@fbricon
Copy link
Collaborator

fbricon commented Nov 15, 2016

@3ximus I don't see why this behavior would be missing on linux, given the rest works. Can you try on another OS?

@3ximus
Copy link
Author

3ximus commented Nov 15, 2016

Yeah. I've tried it on Kali Linux and it has the exact same problem. However on Windows 10 it works fine.

@gorkem
Copy link
Contributor

gorkem commented Nov 15, 2016

@fbricon Syntax highlights are on the vanilla vscode, I think it is best to handle it in there. Opened microsoft/vscode#15527 let's see what vscode team responds.

@gorkem
Copy link
Contributor

gorkem commented Nov 15, 2016

@3ximus Are you missing javadocs for 3rd party libraries or JDK classes?

@3ximus
Copy link
Author

3ximus commented Nov 15, 2016

I haven't tried on any third party libraries, only on JDK classes

@gorkem
Copy link
Contributor

gorkem commented Nov 15, 2016

You probably do not have the source files or javadocs for the JDK classes on your JVM installation. We extract javadocs from either sources or javadocs.

@3ximus
Copy link
Author

3ximus commented Nov 15, 2016

Yes, you are right... My bad. Thanks, keep up the good work 😉

@fbricon
Copy link
Collaborator

fbricon commented Nov 24, 2016

Upstream got it almost working, except for closing tags. See microsoft/vscode#16041
capture d ecran 2016-11-24 a 16 30 07

@fbricon
Copy link
Collaborator

fbricon commented Feb 22, 2017

So microsoft/vscode#16041 has been fixed. Until VS Code 1.10 is released, you need to use the Insider build.

@fbricon fbricon closed this as completed Feb 22, 2017
@fbricon fbricon added this to the Mid March 2017 milestone Feb 22, 2017
@fbricon
Copy link
Collaborator

fbricon commented Mar 1, 2017

VS Code 1.10 was released today, Javadoc looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants