-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javadoc Syntax highlighting #94
Comments
I see. And I agree that's a perfectly legitimate request. You only get javadoc on hover when the java file is opened within a project directory (must be an Maven or Eclipse project), not as a standalone file. |
I do have a maven project open. Everything works, like completion and my custom javadoc is displayed, but not javadoc of classes or methods that I didnt define. |
While javadoc syntax highlighting is probably fixable in vscode-java, I believe this is something that should be fixed upstream, in https://github.com/Microsoft/vscode/blob/master/extensions/java/syntaxes/java.json. @gorkem WDYT? |
@3ximus I don't see why this behavior would be missing on linux, given the rest works. Can you try on another OS? |
Yeah. I've tried it on Kali Linux and it has the exact same problem. However on Windows 10 it works fine. |
@fbricon Syntax highlights are on the vanilla vscode, I think it is best to handle it in there. Opened microsoft/vscode#15527 let's see what vscode team responds. |
@3ximus Are you missing javadocs for 3rd party libraries or JDK classes? |
I haven't tried on any third party libraries, only on JDK classes |
You probably do not have the source files or javadocs for the JDK classes on your JVM installation. We extract javadocs from either sources or javadocs. |
Yes, you are right... My bad. Thanks, keep up the good work 😉 |
Upstream got it almost working, except for closing tags. See microsoft/vscode#16041 |
So microsoft/vscode#16041 has been fixed. Until VS Code 1.10 is released, you need to use the Insider build. |
VS Code 1.10 was released today, Javadoc looks good now. |
Not sure if i should ask this here, but would it be possible for you to add syntax highlighting for javadoc?
The text was updated successfully, but these errors were encountered: