Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package autocompletion should return only 1 package #234

Closed
fbricon opened this issue Jun 8, 2017 · 2 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#260
Closed

package autocompletion should return only 1 package #234

fbricon opened this issue Jun 8, 2017 · 2 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#260
Assignees
@fbricon
Labels
bug content-assist upstream
Milestone
Mid June 2017

Comments

@fbricon
Copy link
Collaborator

fbricon commented Jun 8, 2017

After creating a new java file in a source directory, autocompletion after the package keyword should return the current package, inferred from the file location. Instead, a complete, useless list of packages is returned.
package-autocompletion
@fbricon
Copy link
Collaborator Author

fbricon commented Jun 12, 2017

Created upstream issue https://bugs.eclipse.org/518140

fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Jun 12, 2017
@fbricon
Boost relevance of current package during completion
3f34147 
Current package relevance is boosted but unrelevant packages are still proposed.

Partially fixes redhat-developer/vscode-java#234 until
https://bugs.eclipse.org/518140 is fixed in JDT core.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon mentioned this issue Jun 12, 2017
Merged
@fbricon fbricon self-assigned this Jun 12, 2017
@fbricon
Copy link
Collaborator Author

fbricon commented Jun 12, 2017

completion improvement with eclipse-jdtls/eclipse.jdt.ls#260

jun-12-2017 15-30-38

fbricon added a commit to eclipse-jdtls/eclipse.jdt.ls that referenced this issue Jun 12, 2017
@fbricon
Boost relevance of current package during completion
9c84fda 
Current package relevance is boosted but unrelevant packages are still proposed.

Partially fixes redhat-developer/vscode-java#234 until
https://bugs.eclipse.org/518140 is fixed in JDT core.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon added this to the Mid June 2017 milestone Jun 12, 2017
aeschli pushed a commit to aeschli/eclipse.jdt.ls that referenced this issue Jun 15, 2017
@fbricon @aeschli
Boost relevance of current package during completion
5a18006 
Current package relevance is boosted but unrelevant packages are still proposed.

Partially fixes redhat-developer/vscode-java#234 until
https://bugs.eclipse.org/518140 is fixed in JDT core.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
bug content-assist upstream
Projects
None yet
Milestone
Mid June 2017
Development

Successfully merging a pull request may close this issue.

Boost relevance of current package during completion fbricon/eclipse.jdt.ls
1 participant
@fbricon