Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Use ODO binary from nightly builds #4191

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[build] Use ODO binary from nightly builds #4191

merged 1 commit into from
Jun 28, 2024

Conversation

vrubezhny
Copy link
Contributor

Since the ODO project has stoped producing new releases for ODO binary, the nightly builds became the source of most recent and up-to-date ODO binary version.

Fixes: #4183

@vrubezhny vrubezhny marked this pull request as draft June 8, 2024 13:46
@vrubezhny vrubezhny requested a review from datho7561 June 8, 2024 13:46
@vrubezhny
Copy link
Contributor Author

In case we move to using ODO nightly builds, we do not need limiting the version of 'nodejs' devfile (or potentially of any other component devfiles), so we should close A workaround for 'ODO' stopped working after Devfile schema update to v.2.2.2 #4183 #4185 as not needed anymore

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.89%. Comparing base (da60441) to head (c7084ed).
Report is 323 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #4191       +/-   ##
===========================================
+ Coverage   32.37%   43.89%   +11.52%     
===========================================
  Files          85       95       +10     
  Lines        6505     7711     +1206     
  Branches     1349     1647      +298     
===========================================
+ Hits         2106     3385     +1279     
+ Misses       4399     4326       -73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny vrubezhny force-pushed the fix-check-odo-to-update-from-nightly-builds branch from c96e2cc to 5dfb22b Compare June 9, 2024 17:21
@vrubezhny vrubezhny marked this pull request as ready for review June 9, 2024 18:10
@vrubezhny vrubezhny mentioned this pull request Jun 10, 2024
Closed
@vrubezhny vrubezhny force-pushed the fix-check-odo-to-update-from-nightly-builds branch 2 times, most recently from 1e90f1d to caa5664 Compare June 10, 2024 01:42
@rgrunber rgrunber self-requested a review June 10, 2024 13:50
datho7561
datho7561 previously approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. If something breaks when it runs, we can always fix it or revert it. However, I'm also interested in Roland's review, since he's much more experienced in shell scripting than I am.

rgrunber
rgrunber reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, though I haven't tested if it works in a fork yet.

.github/workflows/check-odo.yml Outdated Show resolved Hide resolved
.github/workflows/check-odo.yml Outdated Show resolved Hide resolved
.github/workflows/check-odo.yml Outdated Show resolved Hide resolved
.github/workflows/check-odo.yml Outdated Show resolved Hide resolved
.github/workflows/check-odo.yml Outdated Show resolved Hide resolved
@vrubezhny vrubezhny force-pushed the fix-check-odo-to-update-from-nightly-builds branch from caa5664 to a7fd89f Compare June 10, 2024 20:08
@vrubezhny vrubezhny marked this pull request as draft June 10, 2024 22:53
@vrubezhny vrubezhny force-pushed the fix-check-odo-to-update-from-nightly-builds branch from a7fd89f to 53536ef Compare June 12, 2024 12:26
@vrubezhny
Copy link
Contributor Author

@rgrunber I've changed the GH Action to download the ODO repository and calculate the nightly-versions as <Last Release Version + 0.0.1>-<Build Number>-nightly which semver is happy about.

Please review.

@vrubezhny vrubezhny marked this pull request as ready for review June 12, 2024 12:44
@vrubezhny vrubezhny requested a review from rgrunber June 12, 2024 12:44
rgrunber
rgrunber reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work. I just think some parts are a bit more complicated than they need to be.

.github/workflows/check-odo.yml Outdated Show resolved Hide resolved
.github/workflows/check-odo.yml Outdated Show resolved Hide resolved
.github/workflows/check-odo.yml Outdated Show resolved Hide resolved
@vrubezhny vrubezhny marked this pull request as draft June 12, 2024 23:27
@vrubezhny vrubezhny force-pushed the fix-check-odo-to-update-from-nightly-builds branch from 53536ef to 636a948 Compare June 17, 2024 11:17
@vrubezhny vrubezhny requested a review from rgrunber June 17, 2024 11:21
@vrubezhny
Copy link
Contributor Author

At the moment, the ODO Team looks like preparing a release for ODO v.3.16.0, so with or without this PR merged, we'll get that update.

But for the future, we'll, probably, still need this PR - ODO Team has added commit numbers to the ODO download URLs - so since then we able to use nightly builds with no problem (as far as I understood, the archive and sha checksum files history is kept, so we can get sha checksum for an archive, download the archive later and check it against the saved sha checksum)

@vrubezhny vrubezhny marked this pull request as ready for review June 17, 2024 13:13
rgrunber
rgrunber reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working as far as generating the PR is conerned. Just found an issue regarding cmdFileName.

.github/workflows/check-odo.yml Outdated Show resolved Hide resolved
@vrubezhny vrubezhny marked this pull request as draft June 18, 2024 13:23
@vrubezhny vrubezhny marked this pull request as draft June 18, 2024 13:23
@vrubezhny vrubezhny force-pushed the fix-check-odo-to-update-from-nightly-builds branch from 636a948 to 374054d Compare June 25, 2024 09:54
@vrubezhny vrubezhny marked this pull request as ready for review June 25, 2024 10:10
@vrubezhny vrubezhny requested a review from rgrunber June 25, 2024 10:10
@vrubezhny vrubezhny force-pushed the fix-check-odo-to-update-from-nightly-builds branch from 374054d to 2351738 Compare June 25, 2024 10:11
@vrubezhny vrubezhny mentioned this pull request Jun 26, 2024
Merged
@vrubezhny vrubezhny force-pushed the fix-check-odo-to-update-from-nightly-builds branch 2 times, most recently from eea693e to 17d2609 Compare June 27, 2024 12:42
rgrunber
rgrunber previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well for me so I would feel free to merge. Only thing I noticed is that because of github.event_name != 'schedule', this will go as far as update-odo even though pr_exists could have it terminate sooner. Is there a use-case for this ?

Otherwise, it seems fine to merge.

@vrubezhny
Copy link
Contributor Author

Seems to be working well for me so I would feel free to merge. Only thing I noticed is that because of github.event_name != 'schedule', this will go as far as update-odo even though pr_exists could have it terminate sooner. Is there a use-case for this ?

The goal is to make it run some steps even if we have no any new commits available in odo repository. But this looks like a check we don't really need as we don't rely on any cache hit/not hit-like event.
I'm going to remove it before I merge.

@vrubezhny vrubezhny force-pushed the fix-check-odo-to-update-from-nightly-builds branch from 17d2609 to 31cd822 Compare June 27, 2024 17:09
@vrubezhny
[build] Use ODO binary from nightly builds
c7084ed 
Since the [ODO project](https://github.com/redhat-developer/odo) has stoped producing new releases
for ODO binary, the [nightly builds](https://odo.dev/docs/overview/installation/#nightly-builds)
became the source of most recent and up-to-date ODO binary version.

Fixes: redhat-developer#4183

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny force-pushed the fix-check-odo-to-update-from-nightly-builds branch from 31cd822 to c7084ed Compare June 28, 2024 11:00
@vrubezhny vrubezhny merged commit 9035c72 into redhat-developer:main Jun 28, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber left review comments

@datho7561 datho7561 datho7561 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'ODO' stopped working after Devfile schema update to v.2.2.2
4 participants
@vrubezhny @codecov-commenter @rgrunber @datho7561