Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle cancelled 'xml/closeTag' requests #149

Closed
fbricon opened this issue Jun 4, 2019 · 0 comments · Fixed by #216
Closed

Gracefully handle cancelled 'xml/closeTag' requests #149

fbricon opened this issue Jun 4, 2019 · 0 comments · Fixed by #216
Assignees
Labels
bug Something isn't working completion
Milestone

Comments

@fbricon
Copy link
Collaborator

fbricon commented Jun 4, 2019

With eclipse/lemminx#412 enabled, rapidly typing closing tags in a large xml document leads to vscode logging errors:

rejected promise not handled within 1 second: Error: The request (id: 19, method: 'xml/closeTag') has been cancelled
extensionHostProcess.js:749
stack trace: Error: The request (id: 19, method: 'xml/closeTag') has been cancelled
	at handleResponse (/Users/fbricon/Dev/projects/vscode-xml/dist/extension.js:6061:48)
	at processMessageQueue (/Users/fbricon/Dev/projects/vscode-xml/dist/extension.js:5888:17)
	at Immediate.module.exports../node_modules/vscode-jsonrpc/lib/main.js.setImmediate (/Users/fbricon/Dev/projects/vscode-xml/dist/extension.js:5872:13)
	at runCallback (timers.js:696:18)
	at tryOnImmediate (timers.js:667:5)
	at processImmediate (timers.js:649:5)

Cancellations should be handled more gracefully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant