Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the XMLServerLauncher process when the extension is deactivated #303

Closed
xorye opened this issue Aug 5, 2020 · 0 comments · Fixed by #305
Closed

Stop the XMLServerLauncher process when the extension is deactivated #303

xorye opened this issue Aug 5, 2020 · 0 comments · Fixed by #305
Milestone

Comments

@xorye
Copy link

xorye commented Aug 5, 2020

Sometimes when you exit VS Code while vscode-xml was running, there is a Java process called XMLServerLauncher that remains.

image

If that process remains, and vscode-xml is started up again, there is an error about the XML language server crashing 5 times in the last 3 minutes.

To fix this problem vscode-xml should call stop() on the languageClient in the deactivate() method, which is what vscode-java does:
https://github.com/redhat-developer/vscode-java/blob/c7afc32bde70f5afc292966c1311ec4dd1bfe9b5/src/extension.ts#L384-L387

to ensure that the process is terminated when the extension is deactivated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants