Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add trailing space to processing instructions #372

Closed
anthonyvdotbe opened this issue Nov 15, 2020 · 3 comments · Fixed by eclipse/lemminx#934
Closed

Don't add trailing space to processing instructions #372

anthonyvdotbe opened this issue Nov 15, 2020 · 3 comments · Fixed by eclipse/lemminx#934
Assignees
Labels
bug Something isn't working enhancement New feature or request formatting
Milestone

Comments

@anthonyvdotbe
Copy link

In #240 (comment) it was decided that:

we should never generate a space before the end of processing instruction

However, I just noticed that this was only resolved for the XML prolog, and not for any other processing instructions. For example <?m2e ignore?> in a pom.xml still formats with a trailing space: <?m2e ignore ?>. To resolve this issue, I guess it should be sufficient to delete this line.

@angelozerr
Copy link
Contributor

@anthonyvdotbe you are right, could you create a PR for that by adjusting tests please.

@anthonyvdotbe
Copy link
Author

@angelozerr I created the PR

@angelozerr angelozerr added this to the 0.15.0 milestone Nov 16, 2020
@angelozerr angelozerr added formatting bug Something isn't working enhancement New feature or request labels Nov 16, 2020
@angelozerr
Copy link
Contributor

Fixed by eclipse/lemminx#934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request formatting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants