Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in XML document in docs #394

Closed
bricksdont opened this issue Jan 25, 2021 · 2 comments
Closed

Error in XML document in docs #394

bricksdont opened this issue Jan 25, 2021 · 2 comments

Comments

@bricksdont
Copy link
Contributor

bricksdont commented Jan 25, 2021

In the docs about XSD validation, one of the XML documents shown is not actually valid with respect to the schema:

https://github.com/redhat-developer/vscode-xml/blob/master/docs/Validation.md#xsischemalocation

The corresponding schema has a "targetNamespace" attribute, which means it expects all elements in the XML document to be in that namespace. The XML in the docs does not have a namespace:

<foo
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://foo foo.xsd">
  <bar />
</foo>

The document should actually have a default namespace, like so:

<foo xmlns="http://foo"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://foo foo.xsd">
  <bar />
</foo>
@bricksdont bricksdont changed the title Error in XML document Error in XML document in docs Jan 25, 2021
@angelozerr
Copy link
Contributor

Thanks @bricksdont for your feedback.

Is there any chance to have a PR?

@angelozerr
Copy link
Contributor

Fixed with #396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants