Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have an option to make "resolve external entities" depending on workspace trust #537

Closed
GitMensch opened this issue Jun 29, 2021 · 2 comments · Fixed by #545
Closed

have an option to make "resolve external entities" depending on workspace trust #537

GitMensch opened this issue Jun 29, 2021 · 2 comments · Fixed by #545
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@GitMensch
Copy link
Contributor

Ideally I'd like to have the setting enabled in trusted workspaces, but be disabled in untrusted workspaces.
Would it be reasonable to switch the current setting from boolean (always/trusted/never) to an enum or should this be a new setting?

@datho7561 datho7561 added the enhancement New feature or request label Jun 29, 2021
@datho7561
Copy link
Contributor

Right now, we support making a local config for your workspace (i.e. .vscode/settings.json), then settting "resolve external entities" in that folder. The local config only applies if the workspace is trusted.

I think it that it would be neat feature to support the workflow you described instead, though.

@rgrunber
Copy link
Member

rgrunber commented Jul 5, 2021

Agreed. If the user has not trusted the workspace we should disable the option (not just at the workspace level).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants