-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foldings received a StackOverflowError while scanning the document #538
Comments
Note: after increasing the setting the output has:
I guess that maybe should also not be the case. |
This is working as intended: it catches the Exception and prevents the server from crashing, but it still sends the log of the Exception to the client.
It looks like this is an upstream bug. See eclipse-lsp4j/lsp4j#544 |
The StackOverFlowError looked quite suspicious, so... eclipse/lemminx#1074. I guess that helps at least with the Stackoverflow in this position, but I have no clue if it removes the need for "Max Items Computed". |
Fixed with eclipse/lemminx#1074 Thank's @GitMensch ! |
Just checked with the current nightly vsix where the fix is included: handling the 32MB test XML works fine with that change and |
Big file, extension notified that only the first 5000 items are shown and drops a hint about the "Max Items Computed" settings, XML Support output has:
I think the check is exactly for the stacktrace to not happen, isn't it?
The text was updated successfully, but these errors were encountered: