Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong minimal engine 1.37.0 mentioned instead of 1.52.0 #554

Closed
apupier opened this issue Jul 22, 2021 · 0 comments · Fixed by #557
Closed

Wrong minimal engine 1.37.0 mentioned instead of 1.52.0 #554

apupier opened this issue Jul 22, 2021 · 0 comments · Fixed by #557
Assignees
@AlexXuChen
Labels
bug Something isn't working
Milestone
0.18.0

Comments

@apupier
Copy link
Member

apupier commented Jul 22, 2021

vscode-xml/package.json

Line 38 in f2039bf

"vscode": "^1.37.0"

but 1.52.0 is required given that vscode-languageclient 7.0.0 dependency requires 1.52.0 version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexXuChen AlexXuChen

Labels
bug Something isn't working
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

upgraded vscode engine from ^1.37.0 to ^1.52.0 AlexXuChen/vscode-xml
3 participants
@apupier @datho7561 @AlexXuChen