Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support platform specific extension #593

Closed
heartacker opened this issue Sep 14, 2021 · 7 comments · Fixed by #720
Closed

Support platform specific extension #593

heartacker opened this issue Sep 14, 2021 · 7 comments · Fixed by #720
Assignees
Labels
build enhancement New feature or request
Milestone

Comments

@heartacker
Copy link

Server binary download failed: certificate signature failure. Cannot start XML language server, since Java is missing.

some like c/c++, https://github.com/microsoft/vscode-cpptools/releases
please provide the offline package for specify platform. OR provide a package that contains all platform server execute file.
thanks

@fbricon
Copy link
Collaborator

fbricon commented Sep 14, 2021

That's an interesting possibility, though we're actually eagerly waiting for platform-specific vsix support from upstream vscode/marketplace: microsoft/vscode#23251

@fbricon fbricon added build enhancement New feature or request labels Sep 14, 2021
@heartacker
Copy link
Author

That's an interesting possibility, though we're actually eagerly waiting for platform-specific vsix support from upstream vscode/marketplace: microsoft/vscode#23251

thsnks, Maybe now you can provide a package that include all perform executefile before that has implemented for nowadays

@rgrunber
Copy link
Member

Yup, this should be possible now with https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions . Looks like we just need to use npm_config_arch and --target for the vsce package command.

@rgrunber rgrunber changed the title provide specify platform offline-package for network trouble user Support platform specific extension Oct 27, 2021
@heartacker
Copy link
Author

hope that we could earn this soon

@heartacker
Copy link
Author

thanks you @rgrunber

@datho7561 datho7561 added this to the 0.21.0 milestone Jun 30, 2022
@GitMensch
Copy link
Contributor

GitMensch commented Jul 20, 2022

I'm a bit confused. Is there still an automatic download of the binary as mentioned in https://github.com/redhat-developer/vscode-xml#requirements?
https://github.com/redhat-developer/vscode-xml/releases/tag/0.21.0 says:

Use platform specific .vsix files, and package the lemminx binary into the .vsix

?!?

Additional: would you mind to place the .vsix into the release assets, too? The current release only contains the lemminx binaries.

@rgrunber
Copy link
Member

We'll need to update the documentation there.

If installing through VS Code and your platform is detected as one of : linux-x64, win32-x64, darwin-x64, or darwin-arm64, then the vsix that will be installed is specific to that platform. If you're on another platform, you'll get the generic vsix, which will download the lemminx binary.

I think we can add the vsix files as well to the release tab. They're archived as part of the build so we can copy them over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants