Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically publish latest snapshot build on Release page #656

Closed
rgrunber opened this issue Feb 9, 2022 · 2 comments · Fixed by #697
Closed

Automatically publish latest snapshot build on Release page #656

rgrunber opened this issue Feb 9, 2022 · 2 comments · Fixed by #697
Labels
Milestone

Comments

@rgrunber
Copy link
Member

rgrunber commented Feb 9, 2022

We can publish our latest snapshot on the releases page under some tag like latest, and as a pre-release, using https://github.com/marvinpinto/action-automatic-releases .

Thanks to @fbricon for investigating this.

@rgrunber rgrunber added the build label Feb 9, 2022
@rgrunber
Copy link
Member Author

rgrunber commented Feb 14, 2022

Slight problem. This would transition our builds to publish vsix snapshots on GH actions and releases would likely remain under Jenkins (for now?). The problem is that every build of a vscode-xml vsix embeds a LemMinX language server. That same language server needs to be built and hosted somewhere as a binary, otherwise our snapshot builds will not support the binary case out-of-the-box.

So a requirement for this is to host the LemMinX binaries as a GitHub release also. I'm guessing this can be hosted on the LemMinX vscode-xml side and there is a GHA script for this. We can just update our binaryServerDownloadUrl as part of the the snapshot builds.

The pain point here is we're porting the builds to GHA for snapshots, which isn't as trivial (due to the binaries), and we still have to maintain the Jenkinsfiles.

@rgrunber
Copy link
Member Author

rgrunber commented Mar 4, 2022

With eclipse/lemminx#1184, we'll have snapshots published to a URL like https://github.com/eclipse/lemminx/releases/download/latest/lemminx-${platform} . We can then use that as the binaryServerDownloadUrl, and then we just need to publish release snapshots for the vsix here.

@rgrunber rgrunber linked a pull request Apr 8, 2022 that will close this issue
@rgrunber rgrunber added this to the 0.21.0 milestone Apr 8, 2022
@rgrunber rgrunber closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant