Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTD validation problems not refreshing correctly #79

Closed
iTReprise opened this issue Nov 6, 2018 · 3 comments
Closed

DTD validation problems not refreshing correctly #79

iTReprise opened this issue Nov 6, 2018 · 3 comments
Assignees
Labels
bug Something isn't working validation
Milestone

Comments

@iTReprise
Copy link

When I change a dtd <!ELEMENT> declaration the file doesn't validate automatically. I have to force restart VSCode to see, if my changes fixed the problem.

Example:

<?xml version="1.0"?>
<!DOCTYPE student [
  <!ELEMENT student (surname,id)>
  <!ELEMENT surname (#PCDATA)>
]>
<student>
  <surname>Smith</surname>
  <id>567896</id>
</student>

This file is invalid because its missing <!ELEMENT id (#PCDATA)>. Adding the line doesn't cause the error to disappear, only after restarting VSCode the problem is it fixed.

I'm using VSCode 1.27.2 on Kali Linux. Java JDK is openjdk-10

@fbricon fbricon added bug Something isn't working validation labels Nov 6, 2018
@fbricon
Copy link
Collaborator

fbricon commented Nov 6, 2018

See upstream issue: eclipse/lemminx#194

@angelozerr
Copy link
Contributor

Indded it should work:

dtd

I think we should add a test with this case.

@fbricon fbricon changed the title Problems not refreshing correctly DTD validation problems not refreshing correctly Nov 6, 2018
@fbricon fbricon added this to the 0.2.0 milestone Nov 6, 2018
@fbricon fbricon self-assigned this Nov 6, 2018
@fbricon
Copy link
Collaborator

fbricon commented Nov 6, 2018

Works in 0.2.0. Please try the latest CI build:

  • Download the latest development VSIX archive from here. (vscode-xml-XXX.vsix)
  • Go to the Extensions section in VSCode.
  • At the top right click the ... icon.
  • Select 'Install from VSIX...' and choose the visx file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validation
Projects
None yet
Development

No branches or pull requests

3 participants