Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creationTimestamp validation incorrect #16

Open
gorkem opened this issue Jun 18, 2017 · 3 comments
Open

creationTimestamp validation incorrect #16

gorkem opened this issue Jun 18, 2017 · 3 comments

Comments

@gorkem
Copy link
Collaborator

gorkem commented Jun 18, 2017

When I have a value such as
creationTimestamp: 2017-06-14T14:29:37Z it is reported as incorrect value type. I think we need better handling of date type.

@JPinkney
Copy link
Contributor

I'm going to be re-writing the validator most likely today to make it more stable. I'll add this to the list of things I'll need to fix in it.

@JPinkney
Copy link
Contributor

I think this is more the schema file needs to be changed then the validator.

"creationTimestamp":{
   "type":"string",
   "description":""
}

That is all the information I have for creationTimestamp and it would be hard to know that's supposed to be a timestamp unless we either:

  1. Checked to see if "Timestamp" is in the name and if it is then validate it like a timestamp
  2. Make a custom rule for it

@gorkem
Copy link
Collaborator Author

gorkem commented Jun 27, 2017

JSON Schema does not have a date type. I think the format field with date-time as value can be a way to express this via a schema.

@gorkem gorkem self-assigned this Jun 23, 2021
@gorkem gorkem removed their assignment May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants