Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Schema from catalog.json in ui #747

Closed
2 of 4 tasks
Nemric opened this issue Apr 16, 2022 · 2 comments · Fixed by redhat-developer/yaml-language-server#714
Closed
2 of 4 tasks

Missing Schema from catalog.json in ui #747

Nemric opened this issue Apr 16, 2022 · 2 comments · Fixed by redhat-developer/yaml-language-server#714
Assignees
Labels

Comments

@Nemric
Copy link

Nemric commented Apr 16, 2022

Describe the bug

I recently pushed a new schema to schemastore.org : "Butane config schema"
Now I want to use it with vscode-YAML with "default" settings.
I just add a setting that map .bu file to .yaml in vscode

"files.associations": {
  "*.bu": "yaml",
  "*.ign": "json"
},

Expected Behavior

When creating or opening a .bu file, vscode :

  • ✔️Map .bu file to .yaml
  • ✔️apply "Butane config schema"
  • ✔️show "Butane config schema" in the list of schemas found in catalog.json from schemastore.org (item 480)

Current Behavior

When creating or opening a .bu file, vscode :

  • ✔️ Map .bu file to .yaml
  • ❌ apply "Butane config schema"
  • ❌ show "Butane config schema" in the list of schemas found in catalog.json from schemastore.org (item 480)

Steps to Reproduce

  1. install vscode-YAML in vscode (currently using ssh-remote on windows to linux box)
  2. Open or create a .bu file
  3. Associate it to a yaml file with vscode langage mode setting
  4. Look at the bottom of vscode window status bar to see "No json schema"
  5. Click the "No json schema" link to open the list of available schemas from store
  6. Type "but..." in search area
  7. See that Schema is not listed

Environment

  • Widows vscode remote ssh
  • Mac
  • Linux vscode server
  • other (please specify)
@gorkem
Copy link
Collaborator

gorkem commented Apr 16, 2022

This is happening because any fileMatch is filtered out of catalog.json that does not end with .yml or .yaml. @evidolob do you recall what we decided to do? We can easily look at file associations and add those mapped to yaml.

@gorkem gorkem added the bug label Apr 16, 2022
@evidolob
Copy link
Collaborator

I think we need to pull files.associations config, and add them in to filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants