Unexpected Diagnostic Positions

[trajamsmith]

Hey again!

We're running into some strange unexpected behavior surrounding the diagnostic positions since upgrading our project's dependency from 0.4.0 -> 0.8.0 (I know it's a pretty big jump).

These are the expected diagnostic positions when using 0.4.0:

Upgrading to 0.8.0, with no other changes at all, the diagnostic positions are no longer correct:

I'm poking around the server locally trying to figure out why this might be the case.

For context, the content of the textDocument is: greetings:↵ hello:↵ hello:↵

[JPinkney]

It looks like duplicate key for some reason is 1 line off. I think something in here:
https://github.com/redhat-developer/yaml-language-server/blob/master/src/languageservice/parser/yamlParser07.ts#L190-L205 is causing it

[trajamsmith]

I think you're right, I think it's specifically something with the .filter().map() here:

yaml-language-server/src/languageservice/parser/yamlParser07.ts

Line 202 in a9169da

const warnings = yamlDoc.errors.filter(e => (e.reason === duplicateKeyReason && isDuplicateAndNotMergeKey(e, text)) || e.isWarning).map(e => convertError(e));

I'll do some more poking around and open a PR if I find a fix — if that's alright with you @JPinkney. Thanks for the prompt response!

[JPinkney]

@trajamsmith Yeah that works for me!

[trajamsmith]

Should be fixed with the #261 merge.