-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support versions from schemastore #639
Support versions from schemastore #639
Comments
What happens if a schema does not have properties like |
I was thinking on providing some some of UI, to allow select schema with specific version |
A schema with 2 versions as separate entries in the schema store is a bug on schema that should be fixed on the schema store. The |
What do you have in mind for UI? |
We don't have a much options, I was thinking on extending status bar item which currently show current schema, I may extend it functionality, and add schema version selection(in case if used schema from json schema store and has more then one version) |
I favor the status bar option too. Code lens is too invasive for this kind of usage |
@gorkem There demo for what I have now: Screen.Recording.2022-02-23.at.16.24.13.movIs it obvious way to change used json schema version? |
@gorkem Could you look on my demo? |
Yes, the UI looks OK. How are we going to remember the selected version? Is it going to be a selection per file/workspace? |
I plan to store it in user preferences, workspace first |
Yes, preferences make sense. |
Schemastore has a
versions
field that lists the older versions of a schema. As you can see from the example below theurl
field points to the latest/default schema whileversions
lists all versions available. We should introduce a code lens to switch between the versions of a schema.Moreover, we can use values of fields such as
apiVersion
orschemaVersion
to match the schema version.The text was updated successfully, but these errors were encountered: