Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hostname on podman/docker run command line #113

Closed
wants to merge 1 commit into from

Conversation

larsks
Copy link
Contributor

@larsks larsks commented Jan 14, 2022

The container hostname is embedded in the generated API certificate. Using
a known hostname (like "microshift") allows the developer to expose the API
at different addresses without invalidating the certificate by placing an
appropriate entry in /etc/hosts or equivalent.

The container hostname is embedded in the generated API certificate. Using
a known hostname (like "microshift") allows the developer to expose the API
at different addresses without invalidating the certificate by placing an
appropriate entry in `/etc/hosts` or equivalent.
@sallyom
Copy link
Contributor

sallyom commented Jan 20, 2022

@larsks I can see this as a "how-to" instead, where you'd include adding the entry in /etc/hosts, a bit about why (valid certificates) and a typical use-case for doing this. It would be a file here: https://github.com/redhat-et/microshift-documentation/tree/main/content/en/docs/user-documentation/how-tos
@fzdarsky wdyt?

@larsks
Copy link
Contributor Author

larsks commented Jan 20, 2022

@sallyom Why not just include this as part of the default instructions? It's not as if it substantially changes the complexity of the existing command line, and it means the generated certificate is immediately more useful. I'm not sure I understand the argument against making the change.

@larsks larsks closed this Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants