Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPCT-270: Added arm64 instructions and multi-arch builds #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OPCT-270: Added arm64 instructions and multi-arch builds #93

wants to merge 1 commit into from

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Oct 23, 2023 •
edited

Creating ARM64 support on OPCT validation environment, it is required to build/mirror multi-arch (amd64 and arm64) the following components:

  • sonobuoy aggregator server/worker image
  • plugin openshift-tests image (and dependencies)
    • tools (base image) and dependencies (oc, jq, etc)
    • must-gather-monitoring image

The build for those components are implemented in the PR redhat-openshift-ecosystem/provider-certification-plugins#51

This PR bumps the Plugins image to use multi-arch payloads starting the next release (v0.5.0-alpha.3). The documentation is also provided with steps to create new builds and to quickly test in an ARM cluster, OCP on AWS with IPI.

Note: I am not updating mkdocs.html to prevent indexing new docs in the current documentation release. cc OPCT-251

https://issues.redhat.com/browse/OPCT-270

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2023
@mtulio mtulio changed the title doc: adding arm64 instructions and multi-arch builds OPCT-270: Adding arm64 instructions and multi-arch builds Oct 24, 2023
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 24, 2023
@mtulio mtulio marked this pull request as ready for review October 24, 2023 22:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Oct 24, 2023 •
edited

This PR is ready for review. I am running a full validation with OPCT on AWS cluster (ARM), one finished I will update it here.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@mtulio mtulio added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 24, 2023
@rvanderp3
Copy link
Contributor

/lgtm
/approve

drop the hold when ready :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

New changes are detected. LGTM label has been removed.

@mtulio mtulio force-pushed the multi-arch-builds branch 2 times, most recently from c986975 to 74917d2 Compare October 24, 2023 22:52
@mtulio
Copy link
Contributor Author

mtulio commented Oct 24, 2023

/lgtm /approve

drop the hold when ready :)

Thanks Richard! I squashed the commits and improved the description.

@mtulio
Copy link
Contributor Author

mtulio commented Oct 25, 2023

This PR is ready for review. I am running a full validation with OPCT on AWS cluster (ARM), one finished I will update it here. /hold

Overall the conformance tests finished correctly. I'll need to recreate the plugins image v0.5.0-alpha.3 due the manual build didn't include the correct(v0.2.0) must-gather-monitoring (mgm) image.

Items to review:

  • mgm image to v0.2
  • improve the error handling when mgm failed - prevent creating empty tarball
  • don't create camgi in ARM64 executions/plugins images - or prevent importing in build time
2023-10-25T02:31:33+00:00 | [plugin] | ./executor.sh:322>  [executor][PluginID#99] Starting Metrics Collector
[must-gather      ] OUT Using must-gather plug-in image: quay.io/opct/must-gather-monitoring:v0.1.0
When opening a support case, bugzilla, or issue please include the following summary data along with any other requested information:


2023-10-25T02:32:50+00:00 | [plugin] | ./executor.sh:326>  [executor][PluginID#99] Packing must-gather-metrics
cp: target 'must-gather-metrics/*/monitoring/': No such file or directory
tar: monitoring: Cannot stat: No such file or directory
tar: Exiting with failure status due to previous errors

@mtulio mtulio mentioned this pull request Oct 25, 2023
Merged
@mtulio mtulio changed the title OPCT-270: Adding arm64 instructions and multi-arch builds OPCT-270: Added arm64 instructions and multi-arch builds Oct 25, 2023
@mtulio
OPCT-270: Adding arm64 instructions and multi-arch builds
75ab330 
Creating ARM64 support on OPCT validation environment, it is required to build/mirror multi-arch (amd64 and arm64) the following components:
- sonobuoy aggregator server/worker image
- plugin openshift-tests image (and dependencies)
  - tools (base image) and dependencies (oc, jq, etc)
  - must-gather-monitoring image

The build for those components are implemented in the PR redhat-openshift-ecosystem/provider-certification-plugins#51

This PR bumps the Plugins image to use multi-arch payloads starting the next release (v0.5.0-alpha.3). The documentation is also provided with steps to create new builds and to quickly test in an ARM cluster, OCP on AWS with IPI.

Note: I am not updating `mkdocs.html` to prevent indexing new docs in the current documentation release. cc [OPCT-251](https://issues.redhat.com/browse/OPCT-251)

https://issues.redhat.com/browse/OPCT-270
@mtulio
Copy link
Contributor Author

mtulio commented Oct 25, 2023

This PR is ready for review. I am running a full validation with OPCT on AWS cluster (ARM), one finished I will update it here. /hold

Overall the conformance tests finished correctly. I'll need to recreate the plugins image v0.5.0-alpha.3 due the manual build didn't include the correct(v0.2.0) must-gather-monitoring (mgm) image.

Items to review:

  • mgm image to v0.2
  • improve the error handling when mgm failed - prevent creating empty tarball
  • don't create camgi in ARM64 executions/plugins images - or prevent importing in build time
2023-10-25T02:31:33+00:00 | [plugin] | ./executor.sh:322>  [executor][PluginID#99] Starting Metrics Collector
[must-gather      ] OUT Using must-gather plug-in image: quay.io/opct/must-gather-monitoring:v0.1.0
When opening a support case, bugzilla, or issue please include the following summary data along with any other requested information:


2023-10-25T02:32:50+00:00 | [plugin] | ./executor.sh:326>  [executor][PluginID#99] Packing must-gather-metrics
cp: target 'must-gather-metrics/*/monitoring/': No such file or directory
tar: monitoring: Cannot stat: No such file or directory
tar: Exiting with failure status due to previous errors

resolved in the opened PR redhat-openshift-ecosystem/provider-certification-plugins#51

Once 51 is merged I will generate a new alpha. PR ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faermanj faermanj Awaiting requested review from faermanj

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtulio @rvanderp3 @openshift-merge-robot