Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] CTA on dark theme #1519

Open
bennypowers opened this issue Apr 10, 2024 · 2 comments
Open

[bug] CTA on dark theme #1519

bennypowers opened this issue Apr 10, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@bennypowers
Copy link
Member

Describe the bug

https://ux.redhat.com/elements/tabs/demo/color-context/
see the CTA on the database tab on a dark theme. background colour does not seem correct to me.

Which Component?

rh-cta

Steps to reproduce

see demo link above
click on database tab
switch to a dark theme
observer cta background colour

Expected behaviour

bg is transparent

Screenshots

image

Element HTML

No response

Operating System (OS)

Linux

Browser

Firefox

More browser information

No response

Additional Info

No response

@bennypowers bennypowers added the bug Something isn't working label Apr 10, 2024
@bennypowers bennypowers self-assigned this Apr 10, 2024
@zeroedin
Copy link
Collaborator

zeroedin commented May 14, 2024

Looks like there is a rh-context-provider in that panel that was missed during the rh-context-provider -> rh-surface transition. I can remove it. I don't think we would want someone combining a dark tab and a light panel thoughts @coreyvickery @marionnegp?

image

If we allow mixing:

image

@coreyvickery
Copy link
Collaborator

@zeroedin Correct, no mixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

3 participants