Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page breaks when clicking manifests link on side nav after manifests page has loaded #1570

Closed
joeldmyers opened this issue Jul 29, 2021 · 2 comments

Comments

@joeldmyers
Copy link
Contributor

joeldmyers commented Jul 29, 2021

Steps to reproduce:

  1. Navigate to https://console.redhat.com/beta/insights/subscriptions/manifests/
  2. Once the page is loaded, click the "manifests" link in the side nav.
  3. The page will route to the 'oops page'. This is because the page is trying to render https://console.redhat.com/beta/insights/subscriptions/manifests**/manifests** which ends up rendering the 404 page view.

Screen Shot 2021-07-29 at 2 22 08 PM

Screen Shot 2021-07-29 at 3 18 01 PM

@Hyperkid123
Copy link
Contributor

@joeldmyers it seems that the APP_NAVIGATION listener in the manifests UI is appending an extra segment to the history. I think here is the issue: https://github.com/RedHatInsights/subscription-central-ui/blob/main/src/App.js#L30

THe appID will be deprecated soon. I advise using event.domEvent.href which has the full path (without /beta/) of the link. Using that and replacing the router basename should work for you.

@Hyperkid123
Copy link
Contributor

@joeldmyers seems like the issue was resolved. Feel free to re-open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants