-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenShift on cloud: settings navigation link #216
Comments
Hi Dan, back when things were flat just needed the app id and we could get rolling. I want to ask here so I dont make assumptions and have to follow up again.
href = /hybrid/settings/catalog-sources
href = /hybrid/settings/cost-management-sources |
That looks good to me. Will update our router to match. Thank you! |
We really need this. Can we please speed this up? |
Sergio, please be patient. This is on our radar, but not in the current sprint. |
Looking at index_map.json and
|
I don't think so real_path is really synonymous with appid at the moment. It's possible that there would be a reason to not have it this way. If some repo housed two apps. With two separate entry point index.htmls... did you all specifically setup cost this way? |
Just looked at the koku-ui source and it doesn't seem to be setup as two different apps with two different index.htmls.... thus I think this config is correct. Happy to change if I am wrong but it will break things if we do it and we don't need to |
Currently, the route in the Cost management is |
I dont get it. I asked, you acked. What do you want the public URL to be? I would persuade you away from choosing @chargio can you please choose a public URL at which you wish for this application to be exposed? It seems like there is some debate here as to what it should be. |
Sorry, I'm not necessarily concerned with the name of the public URL. I'm just trying to figure out what our router path needs to be in order for that link to land on the Cost Management sources page? I have tried changing our router to match /cost-management-sources. For kicks, I also tried other combinations, like /settings/cost-management-sources -- not that I expected that to work. Maybe there is a misunderstanding on my end? However, I don't see my router break point being hit at all when clicking that link. Could this just be an issue with our spandx config? |
I understand but we (my team) absolutely needs to know these details.
So the way this stuff works is your index.html is basically the loader and thus entry point for your entire application. All of an applications resources exist in /apps/$appname/* and we configure proxy "magic" to ensure that the human usable paths (like /hybrid/foo/bar/*) always serve up your apps entry point or index.html.
In development insights-proxy is your proxy to the app so yeah you have to configure net new paths there ... if they are not a subpath of an existing path you'll need to add it. The best example of this stuff is here: In the starter app example for a new path like /hybrid/settings/foo-bar-baz ... you can just add: routes[`/beta/${SECTION}/settings/foo-bar-baz`] = { host: 'http://localhost:8002' };
routes[`/${SECTION}/settings/foo-bar-baz`] = { host: 'http://localhost:8002' }; I strongly recommend getting a few of these config that do various things - one for local frontend, one for local frontend and api, etc - and committing them to your repo so other team members to share. I have some time booked for us Monday, if there is still any confusion lets chat about it there. Should be super simple once you've seen it once. |
Closing due to staleness, if you have another issue with nav, please open it in cloud-services-config |
Per the recent sources meeting (on 3/27), the Cost Management needs a new navigation link, under the bundle 'settings' area. The new page will allow users add and remove sources unique to Cost Management. This link should be named 'Cost Management Sources' and route to /cost-management/sources.
For summit, the left hand nav is expected to look something like this:
Note that the Catalog team will have their own page for sources, with a similar link under the bundle 'settings'. Post summit, it's expected that the Catalog team will combine sources onto one page.
The text was updated successfully, but these errors were encountered: