Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug impl for MultiplexedConnection & Pipeline #649

Closed
elpiel opened this issue Jul 14, 2022 · 2 comments · Fixed by #664
Closed

Debug impl for MultiplexedConnection & Pipeline #649

elpiel opened this issue Jul 14, 2022 · 2 comments · Fixed by #664

Comments

@elpiel
Copy link
Contributor

elpiel commented Jul 14, 2022

Hello,
First of all, thanks for the amazing work on the redis crate!
I'm trying to use the tracing crate for an async application with tokio & tokio-console, however, I'm unable to use the #[instrument] attribute on async function as there is no Debug impl for MultiplexedConnection & Pipeline

Would you consider such addition to the code?
aio::Pipeline seems the most difficult part to implement. What information and other considerations should be taken into account for implementing Debug for Pipeline?

@djc
Copy link
Contributor

djc commented Jul 26, 2022

Yes, I would be open to having Debug implementations for these. I don't have much of an idea about what should be in them, please submit a PR using your best judgement and I'll review from there.

@elpiel
Copy link
Contributor Author

elpiel commented Aug 17, 2022

Ok, let me take a look and see what I can impl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants