make install won't work when INCLUDE_PATH/LIBRARY_PATH is colon seperated

[owensss]

according to Makefile Line 22
INSTALL_INCLUDE_PATH= $(DESTDIR)$(PREFIX)/$(INCLUDE_PATH)

if user set INCLUDE_PATH(which is an environment variable affecting gcc) to some colon seperated string , the header file installation path will be /usr/local//somepath1:/somepath2/libhiredis.so.0.13, this is apparently not a proper position.

same thing with LIBRARY_PATH

---

example

the following is a dry run result in my laptop.

 $ export INCLUDE_PATH=/somepath1:/somepath2
 $ export LIBRARY_PATH=/somepath1:/somepath2  

$ make -n install 
mkdir -p /usr/local//somepath1:/somepath2 /usr/local//somepath1:/somepath2
cp -a hiredis.h async.h read.h sds.h adapters /usr/local//somepath1:/somepath2
cp -a libhiredis.so /usr/local//somepath1:/somepath2/libhiredis.so.0.13
cd /usr/local//somepath1:/somepath2 && ln -sf libhiredis.so.0.13 libhiredis.so
cp -a libhiredis.a /usr/local//somepath1:/somepath2
mkdir -p /usr/local//somepath1:/somepath2/pkgconfig
cp -a hiredis.pc /usr/local//somepath1:/somepath2/pkgconfig

---

solve

I think change ?= to = in line 19, 20, 21 will solve the problem

[badboy]

INCLUDE_PATH is not used by gcc, it uses C_INCLUDE_PATH. LIBRARY_PATH is indeed used, so it might be valid to assume we shouldn't use it.
Changing from ?= to = would make it useless, because it is that way to specifically set these from the outside (not sure if anyone really used it, but here we are)

[ryandesign]

You've fixed this before; see #176. Please fix it again. Reusing compiler environment variables for your own purposes is problematic.

[michael-grunder]

Closing this issue in favor of #806, which should solve the problem and a few others.