Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was the soname bump for 1.0.1 intended? #987

Closed
rgacogne opened this issue Oct 5, 2021 · 4 comments
Closed

Was the soname bump for 1.0.1 intended? #987

rgacogne opened this issue Oct 5, 2021 · 4 comments

Comments

@rgacogne
Copy link

rgacogne commented Oct 5, 2021

As far as I can tell it was not necessary, and will require a rebuild of all packages depending on hiredis. So while it's likely not possible to revert that for 1.0.1, it would be nice to avoid the soname bump for the next security-only releases :)

@michael-grunder
Copy link
Collaborator

I did erroneously bump the SONAME, and you're right it wasn't required. I'm half tempted to just update the GH tag but I can't do that if anyone has already packaged based on the tag.

@rgacogne
Copy link
Author

rgacogne commented Oct 5, 2021

Thank you for the quick reply!
Yeah, I agree that while very tempting it's probably not a good idea to move the tag. I'm tempted to patch the sources in Arch Linux (packager here, hello!) to avoid the soname bump, do you have any opinion on that?
On the other hand I could completely suck it up and rebuild the 7 packages that depends on hiredis at the moment, but that seems a bit wasteful.

@michael-grunder
Copy link
Collaborator

I'm tempted to patch the sources in Arch Linux

That's fine with me, but I've done very little Linux packaging (hence the erroneous SONAME bump 😄). v1.0.1 is completely backward-compatible with v1.0.0.

@rgacogne
Copy link
Author

rgacogne commented Oct 5, 2021

Understood, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants