You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The object generated from parsing this data would contain the following incorrect data:
{config_file: 'Y'}
This issue will occur with any info field containing a colon in the value string, as a result of the key-value parsing logic assuming only two colon-delimited components (key and value) may exist:
I understand that this value is mainly parsed for the intention of checking Redis' loading state, and so complete conformance isn't likely to be an issue here.
However, because this info is eventually exposed under the client's serverInfo field, which some libraries have made use of, there would be some benefit at least in correcting this INFO parser.
The text was updated successfully, but these errors were encountered:
Node version: 10.19.0
ioredis version: 4.16.3
The logic within
_readyCheck
which parses the response of anINFO
query is not fully conformant with this command's response format, and may produce incorrect data in some cases.For instance, given an
INFO
response with:The object generated from parsing this data would contain the following incorrect data:
This issue will occur with any info field containing a colon in the value string, as a result of the key-value parsing logic assuming only two colon-delimited components (key and value) may exist:
https://github.com/luin/ioredis/blob/16a06102fa4fa537be926b7e68601c777f0c64b5/lib/redis/index.ts#L508
I understand that this value is mainly parsed for the intention of checking Redis' loading state, and so complete conformance isn't likely to be an issue here.
However, because this info is eventually exposed under the client's
serverInfo
field, which some libraries have made use of, there would be some benefit at least in correcting thisINFO
parser.The text was updated successfully, but these errors were encountered: