do not catch checked Exception if is not thrown #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bokshitsky any reason for closing this? ps: tests are now passing. |
|
Ouch. Had problems with local tests run - sentinel tests were falling - I though what my branch was not the reason. Thanks, reopen the PR |
|
@sazzad16 what do you think about these changes?
|
|
@bokshitsky My comment about these changes in #2612 still stands. (PS: I get your concern as well.) So I'm just waiting for other reviewers to participate. |
dengliming
previously approved these changes
Aug 24, 2021
gkorland
previously approved these changes
Aug 26, 2021
sazzad16
reviewed
Aug 26, 2021
sazzad16
added a commit
that referenced
this pull request
Sep 30, 2021
* do not catch checked Exception if is not thrown * format import Co-authored-by: Guy Korland <gkorland@gmail.com> Co-authored-by: M Sazzadul Hoque <7600764+sazzad16@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non significant update - tried to put it in previous pr #2612 but you suggested to put in separate
catching checked Exception instead of RuntimeException should be a avoided: it is dangerous due to code inside
tryblock may add new checked exception with special handling required, but author can miss it due to no compile error (especially dangerous for InterruptedException)commit modifies all production files with this "code smell", do not touch tests files due to less dangerous consequences of possible error in them.