Refresh nodes when renewSlotCache #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you please add a reverse test? E.g. start with 4 nodes and end up with 3 nodes after reconfiguration? |
sazzad16
requested review from
dengliming,
gkorland,
mina-asham and
sazzad16
This PR solves redis#2504 redis#2550, when renewSlotCache, we also remove dead nodes according to the latest query.
yangbodong22011
force-pushed
the
feature-cluster-refresh-nodes
branch
from
8ea4e09
to
56192a3
Compare
@sazzad16 done |
sazzad16
approved these changes
Sep 10, 2021
dengliming
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #2504 #2550, when renewSlotCache, we also remove dead nodes according to the
latest query.