Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unit tests for the PubSub commands #2805

Closed
Tracked by #2762
tishun opened this issue Mar 27, 2024 · 0 comments · Fixed by #2808
Closed
Tracked by #2762

Implement unit tests for the PubSub commands #2805

tishun opened this issue Mar 27, 2024 · 0 comments · Fixed by #2808
Labels
type: task A general task

Comments

@tishun
Copy link
Collaborator

tishun commented Mar 27, 2024

Feature Request

Is your feature request related to a problem? Please describe

The unit tests coverage (class/method/line) for the io.lettuce.core.pubsub is 42% / 28% / 40%
A healthy amount is above 75%

Describe the solution you'd like

Implement unit tests for all the classes (minimum) to provide infrastructure
Implement unit tests for a healthy amount of coverage (best case)

Describe alternatives you've considered

We do have coverage by integration tests, but unit tests are run in insolation and could provide better whitebox testing

Teachability, Documentation, Adoption, Migration Strategy

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant