Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLIENT-SETINFO to support suffixes #2612

Closed
chayim opened this issue Sep 13, 2023 · 3 comments · Fixed by #2645
Closed

Update CLIENT-SETINFO to support suffixes #2612

chayim opened this issue Sep 13, 2023 · 3 comments · Fixed by #2645
Assignees

Comments

@chayim
Copy link
Contributor

chayim commented Sep 13, 2023

CLIENT SETINFO should be extended to support community members inserting their own suffixes, for Redis usage.

  1. Clients should by default set-lib during connect with their name and version.
  2. Clients should allow users to not send this
  3. We should allow a user do send a suffix to the LIB-NAME portion - this allows us to learn about how things are used.
  4. Our clients continue to send their version upstream for LIB-VER

Strings should have the client name, and an optional suffix. They should be formatted ClientName(). For example:

  1. If you're NRedisStack - LIB-NAME: NRedisStack(StackExchange.Redis-v2.6.8;.NET-6.2.18) LIB-VERSION: 0.9.1
  2. If you're a project using NRedisStack (say SemtanticKernel): LIB-NAME (NRedisStack(SemanticKernel-v0.1.7;.NET-6.2.18) LIB-VERSION: 0.9.1

Considerations:

  1. Users should not send brackets, or braces, and we should error accordingly.
  2. We should replace spaces a user sends with hyphens
@chayim
Copy link
Contributor Author

chayim commented Nov 1, 2023

See #2456
See #2573

Feel free to close the others - we clearly have dupes.

@sjpotter
Copy link
Contributor

sjpotter commented Nov 1, 2023

I don't have clarity on what this means.

@sjpotter
Copy link
Contributor

sjpotter commented Nov 1, 2023

i.e. we don't have client setinfo support in general in node-redis (i.e. so nothing to update), so is the ticket to add it?

I dont understand what suffix means in that context then.

Or, is it something that is not meant to be exposed to the user directly, but is called simply when we init the client socket to the server (i.e. part of the normal hello/auth path), and we in general use built in contants into the library to set it, but let the user specify a suffix if they want to further distinguish it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants