-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Description
Motivation
Hello,
Recently, I encountered a scenario that requires Redlock algorithm utilization to implement a logic in one of my projects and it turned out node-redis did not have built-in support for Redis locks. As there were no appropriate up-to-date solutions I have decided to implement a custom solution, which is the adaptation of the existing Redlock algorithm implementation designed for the ioredis library - https://github.com/mike-marcacci/node-redlock.
Do you think it is a good idea to submit PR with the adapted Redlock implementation so node-redis could potentially support it?
I will prepare all the documentation and tests and add them to the PR along with the code itself.
My main concern is that the node-redis GitHub repo has some closed Redlock-related issues (see, 1 and 2). In one of them, the reviewer said "This is not a question about node_redis, see Redlock docs and get the info there".
So my question is will my PR even be considered to merge if it corresponds to all the requirements or do the authors of the node-redis consider the Redlock as a separate feature that should be implemented and maintained separately in a view of the separate library with node-redis as a dependency?
Basic Code Example
No response