Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redlock support #2692

Closed
SerhiiPostupaiev opened this issue Jan 19, 2024 · 1 comment
Closed

Redlock support #2692

SerhiiPostupaiev opened this issue Jan 19, 2024 · 1 comment

Comments

@SerhiiPostupaiev
Copy link

Motivation

Hello,

Recently, I encountered a scenario that requires Redlock algorithm utilization to implement a logic in one of my projects and it turned out node-redis did not have built-in support for Redis locks. As there were no appropriate up-to-date solutions I have decided to implement a custom solution, which is the adaptation of the existing Redlock algorithm implementation designed for the ioredis library - https://github.com/mike-marcacci/node-redlock.

Do you think it is a good idea to submit PR with the adapted Redlock implementation so node-redis could potentially support it?
I will prepare all the documentation and tests and add them to the PR along with the code itself.

My main concern is that the node-redis GitHub repo has some closed Redlock-related issues (see, 1 and 2). In one of them, the reviewer said "This is not a question about node_redis, see Redlock docs and get the info there".
So my question is will my PR even be considered to merge if it corresponds to all the requirements or do the authors of the node-redis consider the Redlock as a separate feature that should be implemented and maintained separately in a view of the separate library with node-redis as a dependency?

Basic Code Example

No response

@rawnsley
Copy link

rawnsley commented Feb 5, 2024

I'm not a member of this repository, but I can safely say they would not consider adding Redlock support when it can (and should) be done using another library such as node-redlock. It appears that node-redlock dropped support for node-redis a couple of years ago, but I could not tell you why (and I'm not the only one that wants to know). That is the correct place to submit your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants